Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configbaker container #9574
configbaker container #9574
Changes from 4 commits
a55d6b6
232b1af
18f2137
10505a0
f7a7c42
b9ea230
4e13b39
ceddf70
36a43ac
920770a
ae87556
9e4fcce
13f92f0
63811cc
590763b
e8ebd8f
4014438
c7210d6
8e51e98
77a395c
b54431b
d06e03f
16ea1d1
d672e32
969bd2f
36e4e87
415cfd4
8f7c1d8
c8198a7
044e93a
bf0a43f
cfe167a
32f0977
fdc9b39
b37d501
47f949d
3ab1394
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it strictly necessary to remove the hard coded 8080 in this and other setup scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm awfully sorry me lad, but yes it is.
When you run this script inside a container which is not the application server itself,
localhost
is that container and not the app server. It's like a different machine. If you run this on the host, this works because of the mapped ports, but this will not work on a Windows host.Sorry, hardcoding it never was a good idea, same as the paths not being relative to the script location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW Jenkins made it to the end, so I'm pretty sure I didn't break the scripts 😄