switch dev-env docs to Docker #9761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
added a commit
that referenced
this pull request
Aug 7, 2023
container/dev-usage.rst has not been updated because it will be handled in PR #9761.
scolapasta
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
@sekmiller and I noticed an error at the "run" step if you haven't started Docker yet. Fixed in b798ae9 |
sekmiller
approved these changes
Aug 8, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from In Review 🔎
to Ready for QA ⏩
Aug 8, 2023
|
@kcondon as I mentioned in tech hours, this is safe to merge now, if you're happy with it. The changes will go into the Payara 6 branch. |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
@siacus has asked developers to use the new Dataverse docker containers. Also, now is a good time because we are doing a platform upgrade to Payara 6, etc.
Which issue(s) this PR closes:
Special notes for your reviewer:
Note that until the Payara 6 branch is merged, you must build the base image yourself. See https://dataverse-guide--9685.org.readthedocs.build/en/9685/container/dev-usage.html#building-your-own-base-image
Also, note that this PR builds on the Payara 6 branch so we should merge the Payara 6 branch first.
Suggestions on how to test this:
Try following the instructions. Again, you must build your own base image until the Payara 6 branch is merged.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Probably not.
Additional documentation:
None. This is documentation.