Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable loading of metadata blocks in API tests, more sleep #9873

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Sep 1, 2023

What this PR does / why we need it:

We can't ship 6.0 with failing tests.

Which issue(s) this PR closes:

Special notes for your reviewer:

During the containerization meeting yesterday we talked about why tests are failing at https://github.com/gdcc/api-test-runner . (This was about 20 minutes in at https://harvard.zoom.us/rec/share/Nsm8SZgE05wuziNoGPA9fYNCPoYH1sKqvgS7omn-nclo6qFTsAn-qu-pqF4JnFuZ.joqMRTV6SqSf5gMl ). One avenue to explore is how we load metadata blocks (added in PR #6921) but don't update the Solr schema. Is this a problem?

I disabled two tests with this note: Disabled because once there are new fields in the database that Solr doesn't know about, dataset creation could be prevented, or at least subsequent search operations could fail because the dataset can't be indexed.

It's somewhat mysterious why GitHub Actions is more sensitive to the loading of a metadata block than Jenkins is. Jenkins can be fixed with more sleep in #9874.

See test results below.

Suggestions on how to test this:

Check Jenkins and GitHub Actions.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

Disabled because once there are new fields in the database that Solr
doesn't know about, dataset creation could be prevented, or at least
subsequent search operations could fail because the dataset can't be
indexed.
@pdurbin pdurbin added this to the 6.0 milestone Sep 1, 2023
@pdurbin pdurbin added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Sep 1, 2023
@pdurbin pdurbin self-assigned this Sep 1, 2023
@pdurbin pdurbin moved this from Ready for Review ⏩ to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Sep 1, 2023
@pdurbin
Copy link
Member Author

pdurbin commented Sep 1, 2023

@github-actions

This comment has been minimized.

@pdurbin pdurbin moved this from IQSS Team - In Progress 💻 to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Sep 1, 2023
@pdurbin pdurbin removed their assignment Sep 1, 2023
@pdurbin pdurbin mentioned this pull request Sep 1, 2023
@pdurbin pdurbin changed the title disable loading of metadata blocks in API tests disable loading of metadata blocks in API tests, more sleep Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9868-disable-load-blocks
ghcr.io/gdcc/configbaker:9868-disable-load-blocks

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@donsizemore
Copy link
Contributor

@pdurbin this doesn't look related? I just tested your branch on Rocky 9, and got:
[ERROR] HarvestingServerIT.testMultiRecordOaiSet:609 Wrong number of items on the first ListIdentifiers page ==> expected: <2> but was: <5>"

@pdurbin
Copy link
Member Author

pdurbin commented Sep 5, 2023

@donsizemore that one is a known issue:

Over at https://github.com/gdcc/api-test-runner/blob/5e0f34127c1119cbd80148f1ec32ad561d6fca94/docker-compose-develop.yml I use this to get that test to pass:

  # to get HarvestingServerIT to pass
  - dataverse_oai_server_maxidentifiers=2
  - dataverse_oai_server_maxrecords=2

In dataverse-ansible we do something similar: https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/b409c6aa9aa4a29c1e9660a221f19f06adca8338/tasks/dataverse-optional-settings.yml#L23

@sekmiller sekmiller self-assigned this Sep 5, 2023
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Sep 5, 2023
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. the only two tests that use the deprecated load metadata block util have been disabled.
Any thoughts on when they might be returned?

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from In Review 🔎 to Ready for QA ⏩ Sep 5, 2023
@sekmiller sekmiller removed their assignment Sep 5, 2023
@kcondon kcondon self-assigned this Sep 5, 2023
@kcondon kcondon merged commit 9499d75 into develop Sep 5, 2023
15 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Sep 5, 2023
@kcondon kcondon deleted the 9868-disable-load-blocks branch September 5, 2023 19:40
@pdurbin
Copy link
Member Author

pdurbin commented Sep 5, 2023

I'd like to pick @poikilotherm's brain about why they seem to have an effect in Docker in particular, and apparently only after the Solr or JUnit upgrades. Still a mystery, I'm afraid. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

DataversesIT.testMoveDataverse, DataversesIT.testImportDDI, FilesIT.testAccessFacet (again)
4 participants