support Postgres 16, bump Flyway

[donsizemore]

What this PR does / why we need it:

Add support for Postgres 16 (and correct installer for Postgres 15+).
Flyway appears to support Postgres 16 already; it doesn't complain about versions in server.log.

Which issue(s) this PR closes:

• Closes Postgres 16 is released #9920

Special notes for your reviewer:

Also test in 13 if that remains the recommended version.

Suggestions on how to test this:

Run installer.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

Perhaps to announce support for the new version.

Additional documentation:

None.

[coveralls]

coverage: 20.165%. remained the same
when pulling 8ec0098 on 9920_postgres16
into 871f373 on develop.

[pdurbin]

"Yes! , I see that this version of the Python installer has corrected both bugs." -- https://groups.google.com/g/dataverse-community/c/0gNosyqvAhg/m/3SxpJysJAwAJ

[yorickdowne]

Flyway 10.0.1 does not support PostgreSQL 16. Here's output from a project of mine:

eth-holesky-web3signer-1  | Flyway OSS Edition 10.0.1 by Redgate
eth-holesky-web3signer-1  | 
eth-holesky-web3signer-1  | See release notes here: https://rd.gt/416ObMi
eth-holesky-web3signer-1  | Database: jdbc:postgresql://postgres/web3signer (PostgreSQL 16.1)
eth-holesky-web3signer-1  | WARNING: Flyway upgrade recommended: PostgreSQL 16.1 is newer than this version of Flyway and support has not been tested. The latest supported version of PostgreSQL is 15.
eth-holesky-web3signer-1  | Successfully validated 12 migrations (execution time 00:00.024s)
eth-holesky-web3signer-1  | Current version of schema "public": 00012
eth-holesky-web3signer-1  | Schema "public" is up to date. No migration necessary.

This is a drive-by comment on a project I'm not related with. :) FWIW, recommend waiting for official flyway support - it works right now but isn't supported - and possibly even PostgreSQL 16.2 on the theory that the .2 release is the one that is generally safe to move to.

[donsizemore]

@yorickdowne the Dataverse installation routine is no stranger to that Flyway warning, and Dataverse's use of Flyway is simple enough that in the past developers haven't anticipated (or experienced) any problems. Note that this PR allows installation on newer versions of Postgres (14+) though the recommended version in the documentation remains 13, for now.

[pdurbin]

Just a quick question for now.

[pdurbin]

Can we please have a release note?

Also, for "how to test" is says "run installer" but can this be beefed up a bit? We need to run the installer against pg < 15 and with pg 16 at minimum, right? That should hit the conditional. Do we need to test pg 15 as well? Should the pg < 15 version be 13 since that's what we support? Do we care about pg 14?

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9920-postgres16

ghcr.io/gdcc/configbaker:9920-postgres16

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[pdurbin]

@donsizemore thanks for adding the release note snippet.

Any thoughts on what I wrote about how to test?

[pdurbin]

Jenkins tests were failing so I merged the latest from develop to kick off another run.

[donsizemore]

@donsizemore Any thoughts on what I wrote about how to test?

Just test the installer on Postgres versions 13-16. In Dataverse-Ansible this is most easily achieved by bumping db.postgres.version in group_vars. I'd suppose the target versions would be 13 and 16, but 14 or 15 may be useful to some organizations?

[pdurbin]

Works great. I tested it with PG 13, 15, and 16.

For 15 and above an extra line is printed:

performing database setup
Admin database connectivity succeeds.
PostgreSQL version: 16
PostgreSQL 15 or higher detected. Running GRANT CREATE ON SCHEMA public TO dvnapp;
Database and role created!

I confirmed the UI was available after each test. I'll go ahead and merge it. Thanks, @donsizemore! ❤️