Jain's Congestion avoidance scheme PS + DTCP's APIs changes #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 17, 2015 16:54
…istine-1.3-cas
…dified to accept PCI instead of seq num
…istine-1.3-cas
…into pristine-1.3-cas
This reverts commit b313bc0.
added 6 commits
June 26, 2015 15:40
…istine-1.3-cas
…istine-1.3-cas
|
ACK I have reviewed all the code, since @lbergesio was the mantainer of most of the files. |
sv_update policy and now in the dtcp_sv_update
|
Ack for maintainers |
This completes the changes to fix IRATI#636. dtcp_sv_update should be called with no lock to avoid calling dev_queue_xmit to be called when sending a control pdu with some other lock taken.
DTP's write function was wrongly setting DRF flag by doing pci_flags_set(pci, PDU_FLAGS_DATA_RUN);
…/stack into pristine-1.3-jain-dtcp
kernel: red-ps: dtcp-ps: commented the case where DRF flag is expected
dtp_write was setting DRF flag by doing pci_flags &= PDU_FLAGS_DATA_RUN when it must use |= operator.
in dtcp's ps, the rcv_vector controlling the arriving PDUs was not reset to 0s if the new required size for it was not changed. Common operations while decision time have been moved to a common place outside the if-else.
memeset operation done regardless new vector size.
… duration In order to avoid setting the start of the *first* prev cycle to the time of creation of the n1_port, based on a flag we set this time to a conf value.
…/stack into pristine-1.3-jain-dtcp
Pristine 1.3 jain dtcp
|
I did not realize that new commits on pristine-1.3 produces a minor conflict (MAINTEINERS). Now it is fixed and the PR could be merged |
vmaffione
pushed a commit
that referenced
this pull request
Jul 24, 2015
Jain's Congestion avoidance scheme PS + DTCP's APIs changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #642 but includes some a couple of more things:
-DTCP's sv_update operation has been removed from the DTCP's PS since it is a mechanism.
-Some DTCP's policies hooks' prototypes have been changed in order to accept a PCI instead of just a sequence number.
The Jain's CAS is selfcontained in /irati/plugins/cong_avoidance. It may still need some testing (mostly considering the incoming new feature of the shim-eth-vlan blocking N-1 ports). Nevertheless, this PR is required to be merged due to the changes affecting the stack listed below.
RED plugins directory has been removed since it will be introduced in a dedicated PR.
Please also, obviate the wrong format of the commit messages since they were done some time ago before the new conventions.
ACKs required in addition to myself:
F: MAINTAINERS
Marc Sune <marc.sune (at) bisdn.de>
F: linux/net/rina/rmt-ps-common.c
Miquel Tarzan <miquel.tarzan (at) i2cat.net>
F: linux/net/rina/rmt.c
Miquel Tarzan <miquel.tarzan (at) i2cat.net>