Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme with new information how to install #95

Merged
merged 1 commit into from Apr 25, 2015

Conversation

jankatins
Copy link
Contributor

Make installing from the supplied packages the new default and
mention that only IPython 3.1 and above is supported.

Closes: #54 # windows support

@takluyver
Copy link
Member

IPython 3.0 does work, as far as I know - the problem you encountered with knitpy only affects other applications starting kernels through the IPython API, not IPython applications. (And it's probably possible to work around, but since 3.1 is already out, I don't think it's worth it).

IRkernel::installspec()
```

On Mac, you probably need to `install.packages(... , type="source")`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably? Do we know what happens if you don't?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I have to use it on windows if the repo only has source packages (windows will try binaries first/only and raise something about no packages found if there are no binary packages or the PACKAGE file for binaries is missing). I'm not sure what mac does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway: I think the most sensible thing would be to have someone compile the mac packages and install them via drat in that repo...

@takluyver
Copy link
Member

On any platforms where we're installing source packages, we will still need to have the ZMQ headers installed, e.g. libzmq3-dev on Debian. Otherwise it won't be possible to compile rzmq.

@jankatins
Copy link
Contributor Author

Ok, so do we know anybody with with R and a Mac? If so we could include mac packages and the Readme would become "if you are on win/mac, do this, and on linux install the zmq headers and do that." :-)

@flying-sheep
Copy link
Member

@noamross from #96 apparently has one :)

@sckott
Copy link

sckott commented Apr 24, 2015

i have a mac too - should I test something?

@noamross
Copy link

install.packages(c("rzmq","repr","IRkernel","IRdisplay"), repos="http://irkernel.github.io/", type="source") worked for me

@jankatins
Copy link
Contributor Author

@noamross / @sckott Can you do some package building? Basically checkout all the above packages and then do:

# for g in "rzmq","repr","IRkernel","IRdisplay":
R CMD build %G%
R CMD check %G%_*.tar.gz
R CMD INSTALL --build --compile-both %G%

(Sorry, my bash is rusty, no idea about the loop :-( )

This should produce a lot of *tar.gz (the source packages) and *.tgz (the mac binary packages). The latter could be added to the repo via drat (see here for binary support: eddelbuettel/drat#16)

@noamross
Copy link

IRkernel builds, but check gives this error:

* checking package dependencies ... ERROR
Namespace dependencies not required: ‘base64enc’ ‘repr’

IRdisplay and repr give a couple of warnings on check related to naming/documentation. They build fine.

rmzq builds fine when I remember to git clone --recursive.

I have no idea how universal these builds are. I am on OSX 10.10.2.

Where to upload?

@noamross
Copy link

@takluyver
Copy link
Member

Excellent, thanks. I guess there are a couple of imports we can drop from IRkernel now.

We're just moving towards releasing these packages (#97), so if it's OK, we'll ask you to redo this process in a couple of days with the released versions, and then upload those packages to the repository.

@jankatins
Copy link
Contributor Author

@noamross Ok, so that works. Would you mind doing a PRs for these files? I will put my drat package somewhere and then you could use that to add your packages to the repo (see #90, which has my initial script to build the R repo: adding to a repo is basically a R --slave -e "drat:::insert('package.tgz', repodir='irkernel.github.io')" with the R which built the package (I use both 3.1 and 3.2)

@takluyver
Copy link
Member

Hold off on the PR until we do a release, though - I don't want to make that repo grow ridiculously by adding binaries of unreleased versions.

@flying-sheep
Copy link
Member

uh-oh, now this undoes 1a39243. could you change this so it doesn’t?

@jankatins
Copy link
Contributor Author

@flying-sheep Hopefully i got everything (reduced indention, s/shell/bash/). Not sure if there is more?

Make installing from the supplied packages the new default and
mention that only IPython 3.0 and above is supported.

Closes: IRkernel#54 # windows support
@takluyver
Copy link
Member

Thanks! If this needs more fixes, we can do them in separate PRs - I'm merging now.

takluyver added a commit that referenced this pull request Apr 25, 2015
Update Readme with new information how to install
@takluyver takluyver merged commit 6ff5c4a into IRkernel:master Apr 25, 2015
@noamross
Copy link

Sure, just ping me when you're ready.
On Fri, Apr 24, 2015 at 2:48 PM Thomas Kluyver notifications@github.com
wrote:

Hold off on the PR until we do a release, though - I don't want to make
that repo grow ridiculously by adding binaries of unreleased versions.


Reply to this email directly or view it on GitHub
#95 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Support
5 participants