Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ongoing work for the study_design/timeline branch #342

Closed
4 tasks done
Zigur opened this issue Oct 7, 2019 · 1 comment
Closed
4 tasks done

Ongoing work for the study_design/timeline branch #342

Zigur opened this issue Oct 7, 2019 · 1 comment
Assignees
@Zigur
Milestone
0.12

Comments

@Zigur
Copy link
Contributor

Zigur commented Oct 7, 2019 •
edited
Loading

Missing items before create mode release

  • move the constant into a constants.py file
  • evaluate whether the study-design-config.yml file is needed yet
  • evaluate the major refactoring of the isa-api into at least two packages: isa-core and isa-converters/isa-utils (or something similar)
  • review all the property names in the serialized JSONs describing a study design (see here: https://gitlab.com/datascriptor/study-design-json-schemas/issues/1)
@Zigur Zigur added this to the 0.11 milestone Oct 7, 2019
@Zigur Zigur self-assigned this Oct 7, 2019
Zigur added a commit that referenced this issue Oct 14, 2019
@Zigur
solved merge conflicts #342
c6055db
Zigur added a commit that referenced this issue Oct 14, 2019
@Zigur
removed all the old stuff #342?
712992d
Zigur added a commit that referenced this issue Oct 14, 2019
@Zigur
fixed all tests on create mode after merge #342
224c0a4
Zigur added a commit that referenced this issue Oct 15, 2019
@Zigur
renamed __treatment to isTreatment #342
e1ba912
@Zigur Zigur modified the milestones: 0.11, 0.12 Dec 18, 2019
@Zigur
Copy link
Contributor Author

Zigur commented Jul 7, 2020

For now, we have decided neither to split the source code into multiple repositories nor to generate multiple packages. We may investigate this further in a following milestone.

Zigur added a commit that referenced this issue Nov 9, 2020
@Zigur
major refactoring of contants and error messages #342
d3e5b0d
@Zigur Zigur closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zigur Zigur

Labels
None yet
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
1 participant
@Zigur