Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pertinent error message if no options and/or values are being supplied for a protocol parameter in an Assay workflow #377

Closed
Zigur opened this issue Dec 7, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@Zigur
Copy link
Contributor

Zigur commented Dec 7, 2020

This is part of PR #373

The error message must be something along the lines of "No IRI supplied for ontology annotation {annotation_term}. Please provide a valid IRI or use a string instead of the ontology annotation."

The error actually seems to be related to the lack of selected values for some options (i.e. parameter values or characteristic values) in the workflow. The workflow should be validated beforehand and a meaningful error message should be sent back.

@Zigur Zigur changed the title Add pefgerror message Add pertinent error message if no IRI is provided to Ontology Annotation in assay configs (Datascriptor connectors) Dec 7, 2020
@Zigur Zigur self-assigned this Dec 7, 2020
@Zigur Zigur added the create label Dec 7, 2020
@Zigur Zigur added this to the 0.12 milestone Dec 7, 2020
@Zigur Zigur changed the title Add pertinent error message if no IRI is provided to Ontology Annotation in assay configs (Datascriptor connectors) Add pertinent error message if no options and/or values are being supplied for a protocol parameter in an Assay workflow Dec 14, 2020
@Zigur
Copy link
Contributor Author

Zigur commented Jan 18, 2021

The behaviour was correct. As one of the protocol parameters had no selected values, the resulting assay was empty. Ideally, we should check that all parameters have at least one selected value and return an error message if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant