Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Protocol names in studies generated from Datascriptor #398

Closed
Zigur opened this issue May 24, 2021 · 1 comment
Closed

Duplicate Protocol names in studies generated from Datascriptor #398

Zigur opened this issue May 24, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@Zigur
Copy link
Contributor

Zigur commented May 24, 2021

When an ISA study object is generated from Datascriptor (using isatools.create.connectors.generate_study_design()):

  • if two or more assays have the same protocol in common, then the resulting study will have conflicting names.

The protocol name should also contain the Assay type identifier (i.e. its id, name, or an abbreviation) to make sure that Protocol.name is unique.

This could have to be fixed here: https://github.com/ISA-tools/isa-api/blob/master/isatools/create/model.py#L1120 (at the level of the AssayGraph. generate_assay_plan_from_dict() )

@Zigur Zigur self-assigned this May 24, 2021
@Zigur Zigur added the bug label May 24, 2021
Zigur added a commit that referenced this issue Jul 5, 2021
@Zigur
Copy link
Contributor Author

Zigur commented Jul 5, 2021

This should be fixed with #405

@Zigur Zigur closed this as completed Jul 5, 2021
@Zigur Zigur added this to the 0.13 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant