Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observational variables #367

Merged
merged 9 commits into from
Nov 3, 2020
Merged

Observational variables #367

merged 9 commits into from
Nov 3, 2020

Conversation

Zigur
Copy link
Contributor

@Zigur Zigur commented Nov 2, 2020

This pull request adds support for observational factors to the "create mode".
Tested in conjunction with the latest Datascriptor commit (https://gitlab.com/datascriptor/datascriptor/-/tree/observational-variables) and the ISA REST service this works correctly, serialising the study design to ISA-tab.

@Zigur Zigur self-assigned this Nov 2, 2020
@Zigur Zigur added this to the 0.12 milestone Nov 2, 2020
@coveralls
Copy link

coveralls commented Nov 2, 2020

Coverage Status

Coverage increased (+0.06%) to 66.872% when pulling e8d3081 on observational-variables into 3f3e6b3 on develop.

Copy link
Member

@proccaserra proccaserra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me (I'll log the issue we discussed)

Copy link
Member

@proccaserra proccaserra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. (just logging the issue we've discussed)

@Zigur Zigur merged commit 5bcc091 into develop Nov 3, 2020
@proccaserra proccaserra deleted the observational-variables branch February 22, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants