Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assay improvements - issues #369, #370 #373

Merged
merged 25 commits into from
Dec 15, 2020
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e2cada1
groupings assays by assay type #369 (tests WIP)
Zigur Nov 11, 2020
c9f81d7
removing unused argument; tests wip #369
Zigur Nov 12, 2020
6140f9e
tests work fix #369
Zigur Nov 12, 2020
07a3447
implemented counter by type to name nodes #370
Zigur Nov 16, 2020
348f632
deleted unused files #368
Zigur Nov 17, 2020
484c555
deleted unused files #368 v2
Zigur Nov 17, 2020
ea60094
deleted unused files #368 v3
Zigur Nov 17, 2020
0ddcd89
renamed isatools.create.models to isatools.create.model
Zigur Nov 17, 2020
eaebbc6
clean-up for naming coventions #370
Zigur Nov 17, 2020
2d2d343
extending travis waiting time
Zigur Nov 18, 2020
1ea6eb9
fixing assay name prefix #370
Zigur Nov 18, 2020
73233bf
cleanup
Zigur Nov 18, 2020
387b126
cleanup of print() v2
Zigur Nov 18, 2020
51c146c
removed printout message #374
Zigur Nov 19, 2020
8c7a44b
add support for other RawDataFile types
Zigur Nov 19, 2020
8329115
fixing TypeError: expected string or bytes-like object
Zigur Nov 23, 2020
2479e02
cleanup
Zigur Nov 23, 2020
442f8de
changed naming convention #370
Zigur Nov 23, 2020
b65f0fb
removed spurious print statement #374
Zigur Nov 24, 2020
9a665db
counters starting from 1
Zigur Nov 24, 2020
4c07cab
expanded assay list
Zigur Nov 24, 2020
746fde3
removed spurious print statement v2 #374
Zigur Nov 24, 2020
138e90c
refactoring connectors to harmonize them to Datascriptor; support for…
Zigur Dec 14, 2020
b6d2446
adding study title, description and design type on creation #373
Zigur Dec 15, 2020
47c366e
support for study identifier
Zigur Dec 15, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ install:
- pip install --upgrade pip && pip install -r requirements.txt
- pip install tox-travis
script:
#- flake8 --show-source --exclude=.svn,CVS,.bzr,.hg,.git,isatab_configurator.py,study_design_wizard.py isatools
#- flake8 --show-source --exclude=.svn,CVS,.bzr,.hg,.git,isatab_configurator.py isatools
- behave --no-capture --no-capture-stderr --format=progress features/isa-file-handler.feature
- python -m unittest discover -s tests/
- travis_wait python -m unittest discover -s tests/
- coverage run -m unittest discover -s tests/
- coverage report -m
branches:
Expand Down
27 changes: 0 additions & 27 deletions isatools/create/MTBLS-purge-spurious-factors.py

This file was deleted.

2 changes: 1 addition & 1 deletion isatools/create/assay_templates.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from isatools.create.models import *
from isatools.create.model import *

NAME = 'name'

Expand Down
4 changes: 2 additions & 2 deletions isatools/create/connectors.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from isatools.model import OntologyAnnotation, OntologySource, FactorValue, Characteristic
from isatools.create.models import StudyDesign, NonTreatment, Treatment, StudyCell, StudyArm, SampleAndAssayPlan
from isatools.create.model import StudyDesign, NonTreatment, Treatment, StudyCell, StudyArm, SampleAndAssayPlan
from isatools.create.constants import SCREEN, INTERVENTIONS, BASE_FACTORS, SAMPLE, ORGANISM_PART
from collections import OrderedDict

Expand Down Expand Up @@ -209,7 +209,7 @@ def _generate_characteristics_from_observational_factor(observational_factor_dic

def generate_assay_ord_dict_from_config(datascriptor_assay_config, arm_name, epoch_no):
res = OrderedDict()
res['name'] = datascriptor_assay_config['name']
res['id'], res['name'] = datascriptor_assay_config['id'], datascriptor_assay_config['name']
res['measurement_type'] = _map_ontology_annotation(
datascriptor_assay_config['measurement_type'], expand_strings=True
)
Expand Down
Loading