Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extension #380

Merged
merged 4 commits into from
Jan 18, 2021
Merged

File extension #380

merged 4 commits into from
Jan 18, 2021

Conversation

Zigur
Copy link
Contributor

@Zigur Zigur commented Jan 13, 2021

Tackles issue #378

Behaviour:

  1. Given this "data file" ProductNode with an "extension" property:
[
          "raw spectral data file",
          {
            "node_type": "data file",
            "is_input_to_next_protocols": {
              "value": true
            },
            "extension": {
              "options": ["mzML", "mzXML", "JCAMP-DX"],
              "value": "mzML",
              "newValues": true
            }
          }
]

All the file nodes will have a .mzML extension, taken from "extension.value"

  1. If the "extension" property is missing or no value is supplied, a default .raw extension is appended to the file names.

This can be tested on the notebooks, e.g. here

@coveralls
Copy link

coveralls commented Jan 13, 2021

Coverage Status

Coverage increased (+0.02%) to 71.139% when pulling baf177f on file-extension into 75d864a on develop.

@Zigur Zigur merged commit 702ad66 into develop Jan 18, 2021
@proccaserra proccaserra deleted the file-extension branch February 22, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants