Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket1509: First Linkam command must be "T" #70

Merged
merged 2 commits into from
Aug 31, 2016

Conversation

AdrianPotter
Copy link
Contributor

@AdrianPotter AdrianPotter commented Aug 24, 2016

Description of work

The Linkam95 device expects the T command to always come first. Previously a Pa0 was sent initially that would subsequently be ignored. The Linkam95 DB file has been updated to ensure that the T command comes first with 1 subsequent Pa0 afterwards.

Note that I've created a simple device emulator for the Linkam that will help with this ticket:

ISISComputingGroup/EPICS-DeviceEmulator#3

To test

ISISComputingGroup/IBEX#1509

Acceptance criteria

  • T command sent first when IOC started
  • Pa0 is sent after the first T command
  • Subsequent T commands are not followed by a Pa0

Code Review

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • Does the IOC respond correctly both in full and simulation mode, where it's possible to test both?
  • If there are multiple _0n IOCs, do they run correctly?

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@AdrianPotter AdrianPotter changed the title Remove PINI from mode. Add FLNK to trigger Pa0 on startup Ticket1509: First Linkam command must be "T" Aug 24, 2016
@KathrynBaker KathrynBaker merged commit 8a6d525 into master Aug 31, 2016
@AdrianPotter AdrianPotter deleted the Ticket1509_Linkam_must_send_T_first branch September 16, 2016 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants