Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add individual position indicators #11

Merged
2 commits merged into from
Oct 24, 2018

Conversation

ThomasLohnert
Copy link
Contributor

@ThomasLohnert ThomasLohnert commented Oct 5, 2018

Added records indicating whether the motor is stopped at one of the first 3 motion setpoint positions (for "Motion Setponts Few" OPI).

Related PR: ISISComputingGroup/ibex_gui#812

Issue: ISISComputingGroup/IBEX#3577

@FreddieAkeroyd
Copy link
Member

This has some code duplication and is also not generic. Can we make it generic i.e. create the INPOS* automatically based on number of positions? We should make the INPOS logic a db template, then if we can't get then created automatically we could have the IOC either use a substitutions file or do dbLoadRecordsLoop()

@ThomasLohnert
Copy link
Contributor Author

Template substitution is a bit awkward for macros with other macros as default values, so I went with dbLoadRecordsLoop(). Not passing in the number of setpoints as from the looks of it we don't know these before runtime, and otherwise it would require pulling this out from the number of lines in the lookup file or something like that, which seems a lot of effort for little gain.

Note this means that the motionSetPoints.cmd in the config directory now has to explicitly load the extra .db file for the changed OPI to work properly, which needs to be upgraded on the instruments. I have added an upgrade script for this here: ISISComputingGroup/EPICS-upgrade#19

@ghost ghost merged commit d3d2559 into master Oct 24, 2018
@ghost ghost deleted the Ticket3577_add_individual_position_records branch October 24, 2018 10:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants