Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRIS: Support for IRIS CryoValve #1405

Closed
kjwoodsISIS opened this issue Jul 13, 2016 · 6 comments
Closed

IRIS: Support for IRIS CryoValve #1405

kjwoodsISIS opened this issue Jul 13, 2016 · 6 comments

Comments

@kjwoodsISIS
Copy link
Contributor

kjwoodsISIS commented Jul 13, 2016

As scientist working on IRIS, I need to monitor and control the IRIS CryoValve (i.e. open it or close it).

Acceptance Criteria
  1. I can view and change the PVs which define the state of the ISIS CryoValve.
  2. I can view and change the state of the ISIS CryoValve via the IBEX GUI.
Notes
  1. The IRIS CryoValve is a device that is unique to IRIS.
  2. We can base the IOC and OPI on the existing VI for the IRIS CryoValve. The commands for the CryoValve are very simple - they are documented in the attached readme.txt file.
  3. When we have created the IOC and OPI, ask if we can test it on IRIS.
@AdrianPotter
Copy link

AdrianPotter commented Jul 14, 2016

@kjwoodsISIS kjwoodsISIS changed the title IRIS: Support for ISIS CryoValve IRIS: Support for IRIS CryoValve Jul 14, 2016
@AdrianPotter AdrianPotter self-assigned this Jul 15, 2016
@AdrianPotter
Copy link

I still have 2 cryo valves on my desk. Come get them from me when you want to do the testing.

@IsabellaRey
Copy link

IsabellaRey commented Aug 2, 2016

Minor rework needed:

  • IOC name should be max 8 chars long, and IOC top directory should have same name as IOC
  • Following clarification with Freddie and update of developer Wiki: in the support module, the Makefile in the same directory as the protocol should include the protocol as "DATA += ". This will separate the source protocol from the build protocol, which lives in a data/ directory at the top of the support module. The st.cmd should then set its stream protocol path to "$(IRISCRYOVALVE)/data"

No functionality reviewed yet

@IsabellaRey
Copy link

Following review:

  • Have protocol Makefile add protocol as "DATA += " and st.cmd should set protcol path pointing at the data/ directory (see updated manual)
  • MASTER_RELEASE file: just move CRYVALVE macro up so file is in alphabetical order
  • OPI: add $(NAME) macro at least in the OPI Name property
  • Add emulator

@AdrianPotter
Copy link

All done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants