Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket1405 iris cryo valve #285

Merged
merged 9 commits into from
Aug 4, 2016
Merged

Conversation

AdrianPotter
Copy link
Contributor

@AdrianPotter AdrianPotter commented Jul 19, 2016

Description of work

Add the OPI for the Iris cryo valve IOC

To test

Ticket #1405

Acceptance criteria

The OPI for the Iris Cryo Valve IOC is available as expected and provides the usability expected for the device.


Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Are there system tests in place? Do they test a minimal set of functionality and leave the gui as close as possible to its original state?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

@IsabellaRey IsabellaRey merged commit 443a388 into master Aug 4, 2016
@IsabellaRey IsabellaRey deleted the Ticket1405_Iris_cryo_valve branch August 4, 2016 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants