fix: custom Host header.

traefik/traefik#6502
ISNing · May 3, 2024 · b4f380c · b4f380c
1 parent de61ac8
commit b4f380c
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 8 deletions.
diff --git a/pkg/handler/deleter/delete.go b/pkg/handler/deleter/delete.go
@@ -17,5 +17,9 @@ func Handle(rw http.ResponseWriter, req *http.Request, rule types.Rule) {
 		return
 	}
 
-	req.Header.Del(rule.Header)
+	if strings.EqualFold(rule.Header, "Host") {
+		req.Host = ""
+	} else {
+		req.Header.Del(rule.Header)
+	}
 }
diff --git a/pkg/handler/join/join.go b/pkg/handler/join/join.go
@@ -32,7 +32,11 @@ func Handle(rw http.ResponseWriter, req *http.Request, rule types.Rule) {
 		return
 	}
 
-	req.Header.Set(rule.Header, newHeaderVal)
+	if strings.EqualFold(rule.Header, "Host") {
+		req.Host = newHeaderVal
+	} else {
+		req.Header.Set(rule.Header, newHeaderVal)
+	}
 }
 
 // getValue checks if prefix exists, the given prefix is present,

diff --git a/pkg/handler/rename/rename.go b/pkg/handler/rename/rename.go
@@ -29,14 +29,22 @@ func Handle(rw http.ResponseWriter, req *http.Request, rule types.Rule) {
 		if rule.SetOnResponse {
 			rw.Header().Del(headerName)
 		} else {
-			req.Header.Del(headerName)
+			if strings.EqualFold(rule.Header, "Host") {
+				req.Host = ""
+			} else {
+				req.Header.Del(headerName)
+			}
 		}
 
 		for _, val := range headerValues {
 			if rule.SetOnResponse {
 				rw.Header().Set(rule.Value, val)
 			} else {
-				req.Header.Set(rule.Value, val)
+				if strings.EqualFold(rule.Value, "Host") {
+					req.Host = val
+				} else {
+					req.Header.Set(rule.Value, val)
+				}
 			}
 		}
 	}

diff --git a/pkg/handler/rewrite/rewrite.go b/pkg/handler/rewrite/rewrite.go
@@ -39,7 +39,11 @@ func Handle(rw http.ResponseWriter, req *http.Request, rule types.Rule) {
 		if rule.SetOnResponse {
 			rw.Header().Del(headerName)
 		} else {
-			req.Header.Del(headerName)
+			if strings.EqualFold(headerName, "Host") {
+				req.Host = ""
+			} else {
+				req.Header.Del(headerName)
+			}
 		}
 
 		for _, headerValue := range headerValues {
@@ -51,7 +55,11 @@ func Handle(rw http.ResponseWriter, req *http.Request, rule types.Rule) {
 				if rule.SetOnResponse {
 					rw.Header().Set(rule.Header, replacedHeaderValue)
 				} else {
-					req.Header.Set(headerName, headerValue)
+					if strings.EqualFold(headerName, "Host") {
+						req.Host = headerValue
+					} else {
+						req.Header.Set(headerName, headerValue)
+					}
 				}
 
 				continue
@@ -65,7 +73,11 @@ func Handle(rw http.ResponseWriter, req *http.Request, rule types.Rule) {
 			if rule.SetOnResponse {
 				rw.Header().Add(rule.Header, replacedHeaderValue)
 			} else {
-				req.Header.Add(headerName, replacedHeaderValue)
+				if strings.EqualFold(headerName, "Host") {
+					req.Host = replacedHeaderValue
+				} else {
+					req.Header.Add(headerName, replacedHeaderValue)
+				}
 			}
 		}
 	}

diff --git a/pkg/handler/set/set.go b/pkg/handler/set/set.go
@@ -21,5 +21,9 @@ func Handle(rw http.ResponseWriter, req *http.Request, rule types.Rule) {
 		return
 	}
 
-	req.Header.Set(rule.Header, rule.Value)
+	if strings.EqualFold(rule.Header, "Host") {
+		req.Host = rule.Value
+	} else {
+		req.Header.Set(rule.Header, rule.Value)
+	}
 }