New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom Host header. #6502
Merged
Merged
fix: custom Host header. #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldez
force-pushed
the
fix/custom-host-header
branch
from
March 17, 2020 08:40
07918be
to
637ad26
Compare
jbdoumenjou
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mpl
approved these changes
Mar 17, 2020
traefiker
force-pushed
the
fix/custom-host-header
branch
from
March 17, 2020 17:38
637ad26
to
737f1c6
Compare
traefiker
force-pushed
the
fix/custom-host-header
branch
from
March 17, 2020 23:34
737f1c6
to
14e4eca
Compare
This was referenced Mar 17, 2020
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
ISNing
added a commit
to ISNing/htransformation
that referenced
this pull request
May 3, 2024
tomMoulard
added a commit
to tomMoulard/htransformation
that referenced
this pull request
May 14, 2024
* fix: custom Host header. traefik/traefik#6502 * feat: Use utils package to handle header modifications * review --------- Co-authored-by: Tom Moulard <tom@moulard.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to override the request Host header with the Header middleware.
Motivation
Fix #6500, #5966, #6000
More