Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom Host header. #6502

Merged
merged 1 commit into from Mar 17, 2020
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 17, 2020

What does this PR do?

Allow to override the request Host header with the Header middleware.

Motivation

Fix #6500, #5966, #6000

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Mar 17, 2020
@traefiker traefiker added this to the 2.2 milestone Mar 17, 2020
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 09224e4 into traefik:v2.2 Mar 17, 2020
v2 automation moved this from To review to Done Mar 17, 2020
@ldez ldez deleted the fix/custom-host-header branch March 17, 2020 23:58
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
ISNing added a commit to ISNing/htransformation that referenced this pull request May 3, 2024
tomMoulard added a commit to tomMoulard/htransformation that referenced this pull request May 14, 2024
* fix: custom Host header.
traefik/traefik#6502

* feat: Use utils package to handle header modifications

* review

---------

Co-authored-by: Tom Moulard <tom@moulard.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants