Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "save" button #594

Closed
newton1985 opened this issue Feb 7, 2022 · 13 comments
Closed

add "save" button #594

newton1985 opened this issue Feb 7, 2022 · 13 comments
Assignees
Labels
Feedback Feedback through frontend

Comments

@newton1985
Copy link

Long story short

It would be great to have a save button that allows data to be written to S3 without having to close the study. This would also provide users with quick feedback in case there is some issue communicating with storage.

Expected behaviour

I expect that clicking this button would cause the study data to be stored to S3, but without interrupting use of the study.

Actual behaviour

There is no save button (yet).

Steps to reproduce

n/a

Note: your environment was attached but will not be displayed

@esraneufeld
Copy link
Member

also, a save copy button complementing the save button would be nice.

@pcrespov pcrespov removed their assignment Feb 9, 2022
@esraneufeld
Copy link
Member

if the concern is, that this could end up in too frequent data transfer, perhaps an intelligent save that only saves services in which the data has changed could be envisioned.

@elisabettai elisabettai changed the title add "save" buttton add "save" button Jun 13, 2022
@sanderegg
Copy link
Member

webbrowser

  • click
  • greys out the iframe

webserver

  • POST /projects/{project_id}/nodes/{node_id}:save (long running task)

director-v2

  • POST /v2/dynamic_services/{node_uuid}:save (long running task)
    • then calls the dynamic sidecar to pause (docker pause), save, resume (docker unpause) the service

@elisabettai elisabettai assigned GitHK and unassigned esraneufeld Oct 17, 2022
@GitHK
Copy link
Contributor

GitHK commented Oct 18, 2022

@elisabettai
Copy link
Collaborator

Hi @sanderegg, from what I understood from PM1, this is not high priority for this sprint. I'll move it down in the PM2 board.

Related work is the new messaging from the backend to the frontend and that is also needed for s4l lite release, so I'll add that to the PM2 board (if I find the issue).

For the specifics of starting/stopping dynamic services, we should do more testing before if goes to production (I can help with that).

@sanderegg
Copy link
Member

sanderegg commented Nov 11, 2022

Hi @elisabettai , I created an issue and is now linked here:
ITISFoundation/osparc-simcore#3541

@sanderegg
Copy link
Member

@newton1985 can we close this one?

@newton1985
Copy link
Author

@sanderegg - do I understand correctly that we're dropping the request for this feature in favor of selective start/stop? Also, stopping a service triggers data transfer to storage, correct?

@GitHK
Copy link
Contributor

GitHK commented Feb 28, 2023

When you stop the service, the service's state (usually the workspace) is transferred. All ongoing pending output ports are also waited to finish before closing.

@newton1985
Copy link
Author

Ok, great then yes close this one.

@sanderegg
Copy link
Member

@newton1985 as the owner of the issue you have the final say.
Stopping a service triggers full saving of the service, yes.

@KZzizzle
Copy link
Collaborator

KZzizzle commented Feb 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Feedback through frontend
Projects
None yet
Development

No branches or pull requests

9 participants