Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow Starting dynamic services when idle OR failed #3501

Merged
merged 8 commits into from
Nov 2, 2022
Merged

✨ Allow Starting dynamic services when idle OR failed #3501

merged 8 commits into from
Nov 2, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 2, 2022 •
edited

  • Allow Starting dynamic services also when failed
  • Provide Start button on idle/failed loading page

Bonus

  • Do not remove studies through the API

Start-Stop

What do these changes do?

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Nov 2, 2022
@odeimaiz odeimaiz added this to the Katherine Switzer milestone Nov 2, 2022
@odeimaiz odeimaiz self-assigned this Nov 2, 2022
@odeimaiz odeimaiz changed the title Allow Starting dynamic service when failed ✨ Allow Starting dynamic service when failed Nov 2, 2022
@odeimaiz odeimaiz changed the title ✨ Allow Starting dynamic service when failed ✨ Allow Starting dynamic services when idle OR failed Nov 2, 2022
sanderegg
sanderegg approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3501... hihihi, great thank!

GitHK
GitHK approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 91774ae into ITISFoundation:master Nov 2, 2022
@odeimaiz odeimaiz deleted the feature/start-stop-dynamics-II branch November 2, 2022 13:01
This was referenced Nov 4, 2022
Closed
Closed
@elisabettai
Copy link
Contributor

Target-tested this and seems OK. To test I did the following:

  • Opened "Prep2Go Light copied from AWS 23-09-2022"
  • While having Portainer opened, I started the node "CT Bone Seg" (ff77ee6a-0715-4d24-95d1-1984a9767d62) from the frontend
  • In Portainer, as soon as the dy-sidecar container appeared, I paused the corresponding container
  • After pausing, I killed the container -> The frontend shows the service as "Failed"
  • I was able to re-start the service from the frontend (in the usual way)

Minor note: sometimes I was not able to make the service fail. E.g. I tried to just stop/killing the container (without pausing it) and the service became "Idle" after a bit. I don't think this is worrying, but I can try to reproduce it, if @GitHK or @sanderegg think is relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@elisabettai elisabettai Awaiting requested review from elisabettai

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@mguidon mguidon Awaiting requested review from mguidon

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Katherine Switzer
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@odeimaiz @elisabettai @GitHK @pcrespov @sanderegg