Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix s4l-e2e #3404

Merged
merged 6 commits into from
Oct 3, 2022
Merged

🐛 Fix s4l-e2e #3404

merged 6 commits into from
Oct 3, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 3, 2022

What do these changes do?

  • Fix ti-plan e2e test: interaction with s4l fixed
  • Do some basic interaction in the sim4life e2e test

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #3404 (08a73a7) into master (085e0bd) will decrease coverage by 2.6%.
The diff coverage is n/a.

❗ Current head 08a73a7 differs from pull request most recent head 52d25f6. Consider uploading reports for the commit 52d25f6 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3404     +/-   ##
========================================
- Coverage    79.9%   77.2%   -2.7%     
========================================
  Files         818     818             
  Lines       34680   34680             
  Branches     1363    1363             
========================================
- Hits        27732   26805    -927     
- Misses       6780    7707    +927     
  Partials      168     168             
Flag Coverage Δ
unittests 77.2% <ø> (-2.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) ⬇️
...simcore_service_webserver/meta_modeling_results.py 30.9% <0.0%> (-59.6%) ⬇️
...service_webserver/meta_modeling_version_control.py 27.1% <0.0%> (-57.2%) ⬇️
...core_service_webserver/meta_modeling_iterations.py 31.2% <0.0%> (-56.5%) ⬇️
.../simcore_service_webserver/version_control_core.py 37.5% <0.0%> (-54.7%) ⬇️
...core_service_webserver/version_control_handlers.py 49.5% <0.0%> (-50.5%) ⬇️
.../simcore_service_webserver/version_control_tags.py 54.5% <0.0%> (-45.5%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 42.2% <0.0%> (-44.5%) ⬇️
...c/simcore_service_webserver/login/_registration.py 41.5% <0.0%> (-42.9%) ⬇️
...e_service_webserver/login/handlers_confirmation.py 54.5% <0.0%> (-41.9%) ⬇️
... and 36 more

@odeimaiz odeimaiz added this to the vaporwave milestone Oct 3, 2022
@odeimaiz odeimaiz changed the title Fix e2e/s4l 🐛 Fix s4l-e2e Oct 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@colinRawlings colinRawlings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! O-maiz-ing work as always

Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh Maiz Lord, what a nice job

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit cad4dcd into ITISFoundation:master Oct 3, 2022
@odeimaiz odeimaiz deleted the fix-e2e/s4l branch October 3, 2022 13:52
@odeimaiz odeimaiz mentioned this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants