Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix: p2e #3408

Merged
merged 2 commits into from
Oct 3, 2022
Merged

馃悰 Fix: p2e #3408

merged 2 commits into from
Oct 3, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 3, 2022

What do these changes do?

Fixes a bug from #3404

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Oct 3, 2022
@odeimaiz odeimaiz added this to the vaporwave milestone Oct 3, 2022
@odeimaiz odeimaiz added e2e Bugs found by or related to the end-2-end testing changelog:馃悰bugfix labels Oct 3, 2022
@odeimaiz odeimaiz changed the title Fix/e2e fix 馃悰 Fix: p2e Oct 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #3408 (7c06c12) into master (cad4dcd) will decrease coverage by 7.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3408      +/-   ##
=========================================
- Coverage    82.2%   74.9%    -7.4%     
=========================================
  Files         740     323     -417     
  Lines       32191   16317   -15874     
  Branches     1043       0    -1043     
=========================================
- Hits        26483   12232   -14251     
+ Misses       5604    4085    -1519     
+ Partials      104       0     -104     
Flag Coverage 螖
integrationtests 67.6% <酶> (+16.5%) 猬嗭笍
unittests 64.5% <酶> (-16.2%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) 猬囷笍
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) 猬囷笍
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) 猬囷笍
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-88.0%) 猬囷笍
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) 猬囷笍
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) 猬囷笍
...ce_webserver/studies_dispatcher/_studies_access.py 21.1% <0.0%> (-65.4%) 猬囷笍
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) 猬囷笍
...src/simcore_service_webserver/clusters/handlers.py 34.0% <0.0%> (-63.0%) 猬囷笍
...ver/src/simcore_service_webserver/catalog_units.py 24.0% <0.0%> (-61.2%) 猬囷笍
... and 550 more

@odeimaiz odeimaiz merged commit dbf3481 into ITISFoundation:master Oct 3, 2022
@odeimaiz odeimaiz deleted the fix/e2e-fix branch October 3, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants