🐛 Project copy failing when pennsieve token is active #3509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3509 +/- ##
======================================
Coverage 81.0% 81.0%
======================================
Files 834 834
Lines 35459 35459
Branches 748 748
======================================
Hits 28741 28741
Misses 6528 6528
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. |
| for file_metadata in list_of_files_enveloped.data: | ||
| project_size_bytes += file_metadata.file_size | ||
| project_size = parse_obj_as(ByteSize, project_size_bytes) | ||
| log.info( |
There was a problem hiding this comment.
MINOR: i know this was there before but just as a comment. I do not see the point of logging.INFO a return value. It should be the caller who does that (if needed) since he has both the project_uuid (input) and project_zsiez (output).
For the sake of discussion: imaging we call this function in a for loop to find some specific size ... you get an unwished info log.
There was a problem hiding this comment.
we are anyway not logging info logs
There was a problem hiding this comment.
I remove it. But then I can ask for a lot of the logs... imagine we have 10000 users calling into the handlers...
There was a problem hiding this comment.
I do not mean that you should not put logs. I mean that IMO it should be placed outside this function i.e. by the caller :-)
sanderegg
force-pushed
the
bugfix/datcore_does_not_filter
branch
from
3f4bfc7
to
5e2384c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
This PR changes the call to compute the project size.
BEFORE: would check every storage location to get the total size of the project
AFTER: only computes the project total size reported by the internal Simcore S3 storage location
Rationale: in the way this is currently implemented we cannot ask the Pennsieve to give us this information (missing API, and others)
This problem prevents copying any project or opening templates.
@pcrespov this will need to be hotfixed to production
Related issue/s
relates to ITISFoundation/osparc-issues#644
How to test
Checklist