Apply recurring downtimes on Sundays #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NinjaDateTime uses ISO 8691 to express dates and time, with week days numbered as 1-7, 7 being Sunday. While the input data uses the North American/Islamic system which numbers week days as 0-6, 0 being Sunday. This caused recurring downtimes scheduled on a Sunday to fail, while all other week days worked correctly. With this commit the function which returns the day of the week is updated to use the 0-6 format. Fixes: MON-11684 Signed-off-by: Erik Sjöström <esjostrom@op5.com>
erikdsjostrom
deleted the
bugfix/MON-11684-valid-recurring-downtime-is-not-applied
branch
jimorie
pushed a commit
that referenced
this pull request
Jun 12, 2019
NinjaDateTime uses ISO 8691 to express dates and time, with week days numbered as 1-7, 7 being Sunday. While the input data uses the North American/Islamic system which numbers week days as 0-6, 0 being Sunday. This caused recurring downtimes scheduled on a Sunday to fail, while all other week days worked correctly. With this commit the function which returns the day of the week is updated to use the 0-6 format. Fixes: MON-11684 Signed-off-by: Erik Sjöström <esjostrom@op5.com>
jimorie
added a commit
that referenced
this pull request
Jun 12, 2019
NinjaDateTime uses ISO 8691 to express dates and time, with week days numbered as 1-7, 7 being Sunday. While the input data uses the North American/Islamic system which numbers week days as 0-6, 0 being Sunday. This caused recurring downtimes scheduled on a Sunday to fail, while all other week days worked correctly. With this commit the function which returns the day of the week is updated to use the 0-6 format. Fixes: MON-11684 Signed-off-by: Erik Sjöström <esjostrom@op5.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NinjaDateTime uses ISO 8691 to express dates and time, with week days
numbered as 1-7, 7 being Sunday. While the input data uses the North
American/Islamic system which numbers week days as 0-6, 0 being Sunday.
This caused recurring downtimes scheduled on a Sunday to fail, while all
other week days worked correctly. With this commit the function which
returns the day of the week is updated to use the 0-6 format.
Fixes: MON-11684
Signed-off-by: Erik Sjöström esjostrom@op5.com