upcoming sf 1.0-0 breaks pct

[edzer]

Please see r-spatial/sf#1649

upcoming sf 1.0-0 (submitted) breaks pct, with some invalid geometries. Did you try to use st_make_valid on them, possibly after checking they were valid?

* checking re-building of vignette outputs ... WARNING
Error(s) in re-building vignettes:
--- re-building ‘cycling-potential-uk.Rmd’ using rmarkdown
--- finished re-building ‘cycling-potential-uk.Rmd’

--- re-building ‘km-cycled.Rmd’ using rmarkdown
Quitting from lines 42-46 (km-cycled.Rmd) 
Error: processing vignette 'km-cycled.Rmd' failed with diagnostics:
Evaluation error: Found 1 feature with invalid spherical geometry.
[134] Loop 0 is not valid: Edge 38 has duplicate vertex with edge 41.
--- failed re-building ‘km-cycled.Rmd’

--- re-building ‘pct-international.Rmd’ using rmarkdown
--- finished re-building ‘pct-international.Rmd’

--- re-building ‘pct.Rmd’ using rmarkdown
Linking to GEOS 3.9.0, GDAL 3.2.1, PROJ 7.2.1

Attaching package: 'dplyr'

The following objects are masked from 'package:stats':

    filter, lag

The following objects are masked from 'package:base':

    intersect, setdiff, setequal, union

--- finished re-building ‘pct.Rmd’

--- re-building ‘pct_training.Rmd’ using rmarkdown
Legend for line widths not available in view mode.
Quitting from lines 353-373 (pct_training.Rmd) 
Error: processing vignette 'pct_training.Rmd' failed with diagnostics:
could not find function "st_geometry"
--- failed re-building ‘pct_training.Rmd’

--- re-building ‘uk-cities.Rmd’ using rmarkdown

Attaching package: 'dplyr'

The following objects are masked from 'package:stats':

    filter, lag

The following objects are masked from 'package:base':

    intersect, setdiff, setequal, union

Linking to GEOS 3.9.0, GDAL 3.2.1, PROJ 7.2.1
--- finished re-building ‘uk-cities.Rmd’

SUMMARY: processing the following files failed:
  ‘km-cycled.Rmd’ ‘pct_training.Rmd’

Error: Vignette re-building failed.
Execution halted

* checking PDF version of manual ... OK
* DONE

Status: 1 WARNING, 2 NOTEs
See
  ‘/tmp/pct.Rcheck/00check.log’
for details.

[Robinlovelace]

Cheers Edzer, the package is due a new release soon so good timing. Will take a look and report fixes or any other issues here.

[layik]

Viva sf. I am wondering @edzer and @Robinlovelace, what tool was used to generate the report, and to track packages using current version. Is that some CRAN magic?

[edzer]

tools::check_packages_in_dir, and tools::check_packages_in_dir_changes