Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GradedAxes] Add dual and isdual #1274

Merged
merged 6 commits into from
Dec 3, 2023
Merged

[GradedAxes] Add dual and isdual #1274

merged 6 commits into from
Dec 3, 2023

Conversation

mtfishman
Copy link
Member

This adds a dual function for switching between contravariant and covariant spaces, and a function isdual to check if the space is contravariant or covariant. This is similar to the interface in TensorKit.jl.

@emstoudenmire @ogauthe

@mtfishman mtfishman marked this pull request as ready for review December 3, 2023 20:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cef1c93) 84.05% compared to head (b3ab763) 53.92%.

❗ Current head b3ab763 differs from pull request most recent head e0962e8. Consider uploading reports for the commit e0962e8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1274       +/-   ##
===========================================
- Coverage   84.05%   53.92%   -30.13%     
===========================================
  Files         100       99        -1     
  Lines        8540     8487       -53     
===========================================
- Hits         7178     4577     -2601     
- Misses       1362     3910     +2548     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit 8d014bf into main Dec 3, 2023
8 checks passed
@mtfishman mtfishman deleted the GradedAxes_dual branch December 3, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants