Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][ITensorGPU] Update to latest Metal.jl, fix ITensorGPU CI #1383

Merged
merged 20 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion NDTensors/src/lib/Expose/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,11 @@ using NDTensors.GPUArraysCoreExtensions: cpu
copyto!(expose(y), expose(x))
@allowscalar begin
@test y == x
@test copy(x) == x
if dev == NDTensors.mtl
@test_broken copy(x) == x
mtfishman marked this conversation as resolved.
Show resolved Hide resolved
else
@test copy(x) == x
end
end

y = Base.ReshapedArray(dev(randn(elt, 16)), (4, 4), ())
Expand Down
3 changes: 0 additions & 3 deletions NDTensors/test/ITensors/TestITensorDMRG/TestITensorDMRG.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ reference_energies = Dict([

is_broken(dev, elt::Type, conserve_qns::Val) = false

## Currently Metal fails because we are waiting for `resize!` to be added. Should be in the next metal release
is_broken(dev::typeof(mtl), elt::Type, conserve_qns::Val{true}) = true

include("dmrg.jl")

end
5 changes: 4 additions & 1 deletion NDTensors/test/NDTensorsTestUtils/device_list.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ if "rocm" in ARGS || "all" in ARGS
end
if "metal" in ARGS || "all" in ARGS
## Warning Metal does not work in Julia versions below 1.8
Pkg.add("Metal")
## Essentially compat versioning here because we can't put Metal
## in the Project.toml because it causes issues during testing in
## Julia versions below 1.8
Pkg.add(; name="Metal", version="1.1.0")
mtfishman marked this conversation as resolved.
Show resolved Hide resolved
using Metal
end

Expand Down
Loading