Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user control of combined Index direction #417

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Conversation

mtfishman
Copy link
Member

This adds a dir keyword argument to combiner to control the direction of the combined Index.

This fixes #405, and also addresses an issue brought up in #402 where when the QN ITensor had mixed arrow directions in the left/right indices, when the ITensor was turned into a matrix the combined indices were both Out and the resulting matrix was not block diagonal (an assumption made internally in NDTensors).

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2020

Benchmark result

Judge result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmarks:
    • Target: 4 Jun 2020 - 16:41
    • Baseline: 4 Jun 2020 - 16:46
  • Package commits:
    • Target: eaa143
    • Baseline: d7f3d9
  • Julia commits:
    • Target: 44fa15
    • Baseline: 44fa15
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["contract", "matmul_20"] 0.95 (5%) ✅ 1.00 (1%)
["contract", "matmul_60"] 1.07 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Target

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      24959 s          0 s       8027 s      21928 s          0 s
       #2  2394 MHz      39958 s          0 s       3331 s      12429 s          0 s
       
  Memory: 6.764884948730469 GB (2825.62109375 MB free)
  Uptime: 572.0 sec
  Load Avg:  1.81787109375  1.46240234375  0.79345703125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Baseline

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      47482 s          0 s       8552 s      27071 s          0 s
       #2  2394 MHz      51850 s          0 s       7330 s      24765 s          0 s
       
  Memory: 6.764884948730469 GB (2706.91796875 MB free)
  Uptime: 856.0 sec
  Load Avg:  1.76806640625  1.4833984375  0.97509765625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Target result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 4 Jun 2020 - 16:41
  • Package commit: eaa143
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["contract", "heff_2site"] 6.741 ms (5%) 19.42 MiB (1%) 378
["contract", "matmul_100"] 71.700 μs (5%) 81.69 KiB (1%) 51
["contract", "matmul_20"] 5.920 μs (5%) 6.73 KiB (1%) 50
["contract", "matmul_40"] 13.400 μs (5%) 16.11 KiB (1%) 50
["contract", "matmul_60"] 28.700 μs (5%) 31.69 KiB (1%) 51
["contract", "matmul_80"] 40.800 μs (5%) 53.56 KiB (1%) 51
["dmrg", "1d_S=1_heisenberg"] 27.475 s (5%) 3.012 s 39.62 GiB (1%) 3625349
["dmrg", "1d_S=1_heisenberg_qn"] 22.670 s (5%) 3.500 s 18.16 GiB (1%) 179141541
["inplace", "axpy!"] 20.100 μs (5%) 2.08 KiB (1%) 41

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      24959 s          0 s       8027 s      21928 s          0 s
       #2  2394 MHz      39958 s          0 s       3331 s      12429 s          0 s
       
  Memory: 6.764884948730469 GB (2825.62109375 MB free)
  Uptime: 572.0 sec
  Load Avg:  1.81787109375  1.46240234375  0.79345703125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Baseline result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 4 Jun 2020 - 16:46
  • Package commit: d7f3d9
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["contract", "heff_2site"] 6.777 ms (5%) 19.42 MiB (1%) 378
["contract", "matmul_100"] 72.500 μs (5%) 81.69 KiB (1%) 51
["contract", "matmul_20"] 6.260 μs (5%) 6.73 KiB (1%) 50
["contract", "matmul_40"] 12.900 μs (5%) 16.11 KiB (1%) 50
["contract", "matmul_60"] 26.901 μs (5%) 31.69 KiB (1%) 51
["contract", "matmul_80"] 40.900 μs (5%) 53.56 KiB (1%) 51
["dmrg", "1d_S=1_heisenberg"] 26.640 s (5%) 2.350 s 39.61 GiB (1%) 3599253
["dmrg", "1d_S=1_heisenberg_qn"] 21.957 s (5%) 3.047 s 18.15 GiB (1%) 179112107
["inplace", "axpy!"] 19.500 μs (5%) 2.08 KiB (1%) 41

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      47482 s          0 s       8552 s      27071 s          0 s
       #2  2394 MHz      51850 s          0 s       7330 s      24765 s          0 s
       
  Memory: 6.764884948730469 GB (2706.91796875 MB free)
  Uptime: 856.0 sec
  Load Avg:  1.76806640625  1.4833984375  0.97509765625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               63
Model name:          Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping:            2
CPU MHz:             2394.453
BogoMIPS:            4788.90
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            30720K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor :Intel
Architecture :Haswell
Model Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 30720) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2020

Benchmark result

Judge result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmarks:
    • Target: 4 Jun 2020 - 18:10
    • Baseline: 4 Jun 2020 - 18:14
  • Package commits:
    • Target: dc8506
    • Baseline: d7f3d9
  • Julia commits:
    • Target: 44fa15
    • Baseline: 44fa15
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["contract", "heff_2site"] 0.89 (5%) ✅ 1.00 (1%)
["contract", "matmul_100"] 0.87 (5%) ✅ 1.00 (1%)
["contract", "matmul_20"] 0.87 (5%) ✅ 1.00 (1%)
["contract", "matmul_40"] 0.92 (5%) ✅ 1.00 (1%)
["contract", "matmul_60"] 0.89 (5%) ✅ 1.00 (1%)
["contract", "matmul_80"] 0.90 (5%) ✅ 1.00 (1%)
["dmrg", "1d_S=1_heisenberg"] 0.95 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Target

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      25945 s          0 s      11282 s     177854 s          0 s
       #2  2095 MHz      34080 s          0 s       3781 s     178285 s          0 s
       
  Memory: 6.7648773193359375 GB (2819.703125 MB free)
  Uptime: 2178.0 sec
  Load Avg:  1.8115234375  1.3232421875  0.666015625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      37127 s          0 s      16361 s     187485 s          0 s
       #2  2095 MHz      53271 s          0 s       4682 s     184103 s          0 s
       
  Memory: 6.7648773193359375 GB (2755.78515625 MB free)
  Uptime: 2438.0 sec
  Load Avg:  1.685546875  1.40234375  0.85791015625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Target result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 4 Jun 2020 - 18:10
  • Package commit: dc8506
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["contract", "heff_2site"] 6.196 ms (5%) 19.42 MiB (1%) 378
["contract", "matmul_100"] 50.103 μs (5%) 81.69 KiB (1%) 51
["contract", "matmul_20"] 4.029 μs (5%) 6.73 KiB (1%) 50
["contract", "matmul_40"] 8.334 μs (5%) 16.11 KiB (1%) 50
["contract", "matmul_60"] 20.101 μs (5%) 31.69 KiB (1%) 51
["contract", "matmul_80"] 28.202 μs (5%) 53.56 KiB (1%) 51
["dmrg", "1d_S=1_heisenberg"] 26.781 s (5%) 2.352 s 39.62 GiB (1%) 3625349
["dmrg", "1d_S=1_heisenberg_qn"] 20.150 s (5%) 3.119 s 18.16 GiB (1%) 179133827
["inplace", "axpy!"] 14.200 μs (5%) 2.08 KiB (1%) 41

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      25945 s          0 s      11282 s     177854 s          0 s
       #2  2095 MHz      34080 s          0 s       3781 s     178285 s          0 s
       
  Memory: 6.7648773193359375 GB (2819.703125 MB free)
  Uptime: 2178.0 sec
  Load Avg:  1.8115234375  1.3232421875  0.666015625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 4 Jun 2020 - 18:14
  • Package commit: d7f3d9
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["contract", "heff_2site"] 6.942 ms (5%) 19.42 MiB (1%) 378
["contract", "matmul_100"] 57.602 μs (5%) 81.69 KiB (1%) 51
["contract", "matmul_20"] 4.629 μs (5%) 6.73 KiB (1%) 50
["contract", "matmul_40"] 9.034 μs (5%) 16.11 KiB (1%) 50
["contract", "matmul_60"] 22.501 μs (5%) 31.69 KiB (1%) 51
["contract", "matmul_80"] 31.502 μs (5%) 53.56 KiB (1%) 51
["dmrg", "1d_S=1_heisenberg"] 28.196 s (5%) 2.429 s 39.61 GiB (1%) 3599649
["dmrg", "1d_S=1_heisenberg_qn"] 20.407 s (5%) 3.042 s 18.12 GiB (1%) 179101529
["inplace", "axpy!"] 14.200 μs (5%) 2.08 KiB (1%) 41

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      37127 s          0 s      16361 s     187485 s          0 s
       #2  2095 MHz      53271 s          0 s       4682 s     184103 s          0 s
       
  Memory: 6.7648773193359375 GB (2755.78515625 MB free)
  Uptime: 2438.0 sec
  Load Avg:  1.685546875  1.40234375  0.85791015625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               85
Model name:          Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Stepping:            4
CPU MHz:             2095.142
BogoMIPS:            4190.28
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            1024K
L3 cache:            36608K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@mtfishman mtfishman merged commit 6dfc0a7 into master Jun 4, 2020
@mtfishman mtfishman deleted the combiner_dir branch June 4, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow arrow direction to be specified in combiner
1 participant