Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues takatomo #146

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Accessibility issues takatomo #146

merged 3 commits into from
Mar 26, 2024

Conversation

tubesoft
Copy link
Collaborator

Fix for the SiteImprove accessibility issues and one rendering issue (#145)

@mdalmau
Copy link
Collaborator

mdalmau commented Mar 26, 2024

I have closed most of the issues that are part of the PR. If testing on newton dev reveals differently, I can re-open. I will now issue a merge request so we can take advantage of the auto update to newton dev. @randalldfloyd : I feel like most of these changes we can really test-test unless we update to production so can we work on scheduling that?

@mdalmau mdalmau merged commit 8532a0e into master Mar 26, 2024
@randalldfloyd
Copy link
Contributor

@mdalmau @tubesoft

If the automated deployment I setup is working correctly, all of these things should be available for testing on the devel instance in some reasonable amount of time after the recent merge. Even #143 should be testable, just visually inspect the links being generated for search results pagination to verify that they don't accumulate page number references in the parameter list.

@randalldfloyd
Copy link
Contributor

@mdalmau @tubesoft

The devel instance was updated/restarted with this PR merged, and is currently reporting the latest commit level. So the entire set of changes should be testable there.

@mdalmau
Copy link
Collaborator

mdalmau commented Mar 26, 2024

@tubesoft : can you check this on:
http://newton-devel.dlib.indiana.edu -- you'll need to be on the VPN.

I am not sure I'll know what to look for exactly based on what Randall stated below.

Thanks!

@mdalmau @tubesoft

If the automated deployment I setup is working correctly, all of these things should be available for testing on the devel instance in some reasonable amount of time after the recent merge. Even #143 should be testable, just visually inspect the links being generated for search results pagination to verify that they don't accumulate page number references in the parameter list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants