Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendition issues #99

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Rendition issues #99

merged 4 commits into from
Feb 4, 2021

Conversation

randalldfloyd
Copy link
Contributor

No description provided.

@randalldfloyd randalldfloyd changed the title Rendition issues WIP Rendition issues Dec 18, 2020
@tubesoft
Copy link
Collaborator

tubesoft commented Dec 21, 2020

Sorry for the confusing modification. Maybe because the character for the indentation (such as tab and space) was unintentionally replaced, almost all the code seems to be changed. However, I just modified the very last part of bibliography-to-html.xsl that is:
Before:

	<xsl:template match="hi[@rendition='#i']">
		<xsl:element name="span">
			<xsl:attribute name="class" select=" 'rendition-i' "/>
			<xsl:apply-templates/>
		</xsl:element>
	</xsl:template>

and after:

    <xsl:template match="hi">
        <xsl:element name="span">
            <xsl:attribute name="class" select=" replace(@rendition,'#', 'rendition-') "/>
            <xsl:apply-templates/>
        </xsl:element>
    </xsl:template>

Also, we have to be careful when merging that @Conal-Tuohy also modified the same file and committed in the master branch. His commit comment says "render publisher and date in bibliography, to fix issue #88"

@tubesoft
Copy link
Collaborator

I think it is ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants