Fix bug in readline handling if multiple lines available #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See IanHarvey#354 bluepy may read multiple lines from the helper, but readline only returns the first one. Subsequent calls to poll() will delay (and possibly return None) because there is no way to know that additional lines are ready to return. This uses a very simple loop to queue an entry every time readline returns a line. The queue lets you easily check for ready lines, as well as supporting get() with a timeout.
edwios
added a commit
to edwios/bluepy
that referenced
this pull request
Mar 29, 2019
Merged response queue from IanHarvey#355 to capture all BLE responses in _lineq Added debugging for Threads (all those rnd thingys) In _waitResp(), put back to the queue if that is not yours (still not optimal. Proper way is for a fully thread aware approach) Added time out in _getResp() so that _getResp() will always return
|
This PR fixes a bad behavior that I'm seeing where notifications come in delayed- I'm expecting 2 notifications but I only get 1. Then next time I'm expecting 2 notifications, I get the 1 previously missing one and 1 new one (the expected 2nd new one is now delayed until next time). |
|
How do I install this patch on a Hass.io system? |
csonsino
pushed a commit
to csonsino/bluepy
that referenced
this pull request
Apr 28, 2020
csonsino
added a commit
to csonsino/bluepy
that referenced
this pull request
May 22, 2020
* Apply upstream PR 355 IanHarvey#355 * Update version to 1.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #354
bluepy may read multiple lines from the helper, but readline only
returns the first one. Subsequent calls to poll() will delay (and
possibly return None) because there is no way to know that additional
lines are ready to return.
This uses a very simple loop to queue an entry every time readline
returns a line. The queue lets you easily check for ready lines, as
well as supporting get() with a timeout.