Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default fonts are changed to system fonts. #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

batuhansk
Copy link

@batuhansk batuhansk commented Nov 21, 2018

Forcing to use custom fonts and huge codebase are unnecessary. So, I deleted custom fonts then removed unnecessary lines for loading custom fonts that comes with library.

Batuhan Saka added 3 commits November 21, 2018 14:43
Forcing to use custom fonts and huge code-base are unnecessary. It looks great now. 🤙🏼
@JoaoCPires
Copy link

This might look like a small change but it’s very welcome in my opinion.

I’d risk to say most projects stay with the default system fonts unless they have an extremely stylized design.

Having the library default to a font that has nothing to do with most projects just adds unneeded complexity to an otherwise very accessible library.

Sent with GitHawk

@danlozano
Copy link
Contributor

Agreed. This is a good change. Will test and merge ASAP.

@cliftonlabrum
Copy link

@danlozano This is a great change. Can you merge this PR or give another collaborator rights to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants