Add before callback to support plugins #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
force-pushed
the
before_callback
branch
from
9c267a0
to
3f69af5
Compare
paulmelnikow
commented
Apr 12, 2017
| }) | ||
| .toss(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@cvega This test is new since your last review.
| @@ -822,29 +870,35 @@ describe('Frisby matchers', function() { | |||
| .toss(); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
This change restores global setup to avoid a test failure in the new tests.
This was referenced Apr 12, 2017
paulmelnikow
added a commit
to paulmelnikow/IcedFrisby
that referenced
this pull request
Apr 13, 2017
paulmelnikow
added a commit
that referenced
this pull request
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.