Break toss() into methods and test the key behaviors of after() callbacks #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve readability by making the methods shorter. - Avoid using `it` as an identifier, since it is a Mocha global. - Remove parameter to `toss()`, which is redundant with `retry()`, and was broken - Remove useless assignment to `retry` variable
|
There's a failing test in here, the fix for which is in #28. |
Closed
|
Got 👍 offline from @cvega. |
paulmelnikow
commented
Apr 15, 2017
| * @return {object} | ||
| * @desc Run the current Frisby test | ||
| */ | ||
| Frisby.prototype.toss = function (retry) { |
There was a problem hiding this comment.
At present, the retry parameter is broken. Does anyone know how recently it worked? Trying to judge whether or not it's a breaking change. If it's never worked for example, then removing it would certainly not be a breaking change.
There was a problem hiding this comment.
Despite completely refactoring this library, I don't recall ever even using it or seeing it used.
There was a problem hiding this comment.
Okay. Let's consider this a "hygiene" change, then. We're nominally removing a parameter, but it's vestigial and doesn't do anything, so it's like a bug fix, and we'll bump the patch version.
# Conflicts: # lib/icedfrisby.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.