Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accessing deleted record #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

infabo
Copy link

@infabo infabo commented Aug 10, 2022

No description provided.

@IchHabRecht
Copy link
Owner

Hi @infabo

Would you mind to describe how I can reproduce the mentioned problem? As far as I see and understand, it's not wrong having an error when dealing with non-existent records.

@infabo
Copy link
Author

infabo commented Aug 30, 2022

Unfortunately I can't remember after 3 weeks anymore. I need to refresh my mind first. ;)

@infabo
Copy link
Author

infabo commented Aug 30, 2022

OK, I can remember now.

If you use the TYPO3 history/rollback functionality you possibly deal with deleted record UIDs. You either skip "content-defending" when in a rollback - which is actually not possible because rollback uses DataHandler and you don't know the context. Or you avoid access on deleted records - which this PR adds.

@infabo
Copy link
Author

infabo commented Sep 1, 2023

Still a thing in 2023. Soon 2024 - don't miss out this PR. Thanks

@IchHabRecht
Copy link
Owner

Hi @infabo,

Still not able to reproduce the problem. Maybe you want to add some guide what to do and where to click. With some kind of expectations and what's a problem. Thanks for your nice help!

@infabo
Copy link
Author

infabo commented Sep 1, 2023

It happens when you perform a history rollback of a tt_content record. When insert and delete is rolled back in the same "rollback action", the error occurs.

image

@infabo
Copy link
Author

infabo commented Sep 1, 2023

Pretty tough to create the right scenario from scratch, so it is reproducible. I'll come back to this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants