Fix active list item handling #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncosta-ic
requested changes
Jun 20, 2024
raviks789
force-pushed
the
fix/active-list-item-handling
branch
from
3e84c7a
to
2653a53
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ncosta-ic
previously approved these changes
Jun 21, 2024
nilmerg
requested changes
Jun 24, 2024
| $this->getAttributes()->set('data-action-item', true); | ||
| $this->getAttributes() | ||
| ->set('data-action-item', true) | ||
| ->set('data-icinga-detail-filter', QueryString::render(Filter::equal('id', $this->item->id))); |
There was a problem hiding this comment.
We should stay consistent and use Icinga\Module\Notifications\Common\Links for path references to strengthen the maintainability.
I'd extend this to query param references:
Links::contactGroup($this->item->id)->getQueryString()
raviks789
force-pushed
the
fix/active-list-item-handling
branch
from
2653a53
to
68f7fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #212
requires Icinga/ipl-web#225