Merge pull request #9715 from Icinga/StatusDataWriter

Remove StatusDataWriter which has been deprecated for 5 major versions
Icinga · Mar 31, 2023 · 7a7902c · 7a7902c
2 parents 82f9e43 + bbf2e80
commit 7a7902c
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 1,085 deletions.
diff --git a/doc/09-object-types.md b/doc/09-object-types.md
@@ -1915,34 +1915,6 @@ When rotating the performance data file the current UNIX timestamp is appended t
 in `host_perfdata_path` and `service_perfdata_path` to generate a unique filename.
 
 
-### StatusDataWriter <a id="objecttype-statusdatawriter"></a>
-
-Periodically writes status and configuration data files which are used by third-party tools.
-This configuration object is available as [statusdata feature](14-features.md#status-data).
-
-> **Note**
->
-> This feature is DEPRECATED and may be removed in future releases.
-> Check the [roadmap](https://github.com/Icinga/icinga2/milestones).
-
-Example:
-
-```
-object StatusDataWriter "status" {
-    status_path = "/var/cache/icinga2/status.dat"
-    objects_path = "/var/cache/icinga2/objects.cache"
-    update_interval = 30s
-}
-```
-
-Configuration Attributes:
-
-  Name                      | Type                  | Description
-  --------------------------|-----------------------|----------------------------------
-  status\_path              | String                | **Optional.** Path to the `status.dat` file. Defaults to CacheDir + "/status.dat".
-  objects\_path             | String                | **Optional.** Path to the `objects.cache` file. Defaults to CacheDir + "/objects.cache".
-  update\_interval          | Duration              | **Optional.** The interval in which the status files are updated. Defaults to `15s`.
-
 ### SyslogLogger <a id="objecttype-sysloglogger"></a>
 
 Specifies Icinga 2 logging to syslog.

diff --git a/doc/14-features.md b/doc/14-features.md
@@ -1157,25 +1157,6 @@ VACUUM
 >
 > Don't use `VACUUM FULL` as this has a severe impact on performance.
 
-### Status Data Files <a id="status-data"></a>
-
-> **Note**
->
-> This feature is DEPRECATED and may be removed in future releases.
-> Check the [roadmap](https://github.com/Icinga/icinga2/milestones).
-
-Icinga 1.x writes object configuration data and status data in a cyclic
-interval to its `objects.cache` and `status.dat` files. Icinga 2 provides
-the `StatusDataWriter` object which dumps all configuration objects and
-status updates in a regular interval.
-
-```bash
-icinga2 feature enable statusdata
-```
-
-If you are not using any web interface or addon which uses these files,
-you can safely disable this feature.
-
 ### Compat Log Files <a id="compat-logging"></a>
 
 > **Note**

diff --git a/doc/23-migrating-from-icinga-1x.md b/doc/23-migrating-from-icinga-1x.md
@@ -1043,7 +1043,7 @@ In Icinga 2 notification commands are not directly associated with users.
 Instead the notification command is specified inside `Notification` objects next to
 user and user group relations.
 
-The `StatusDataWriter`, `IdoMySqlConnection` and `LivestatusListener` types will
+The `IdoMySqlConnection` and `LivestatusListener` types will
 provide the contact and contactgroups attributes for services for compatibility
 reasons. These values are calculated from all services, their notifications,
 and their users.
@@ -1281,7 +1281,7 @@ provided separately.
 There is no output length restriction as known from Icinga 1.x using an
 [8KB static buffer](https://docs.icinga.com/latest/en/pluginapi.html#outputlengthrestrictions).
 
-The `StatusDataWriter`, `IdoMysqlConnection` and `LivestatusListener` types
+The `IdoMysqlConnection` and `LivestatusListener` types
 split the raw output into `output` (first line) and `long_output` (remaining
 lines) for compatibility reasons.
 
@@ -1471,7 +1471,7 @@ chapter.
 
 Dependencies can be applied to hosts or services using the [apply rules](17-language-reference.md#apply).
 
-The `StatusDataWriter`, `IdoMysqlConnection` and `LivestatusListener` types
+The `IdoMysqlConnection` and `LivestatusListener` types
 support the Icinga 1.x schema with dependencies and parent attributes for
 compatibility reasons.
 

diff --git a/etc/icinga2/features-available/statusdata.conf b/etc/icinga2/features-available/statusdata.conf
diff --git a/lib/compat/CMakeLists.txt b/lib/compat/CMakeLists.txt
@@ -3,13 +3,11 @@
 mkclass_target(checkresultreader.ti checkresultreader-ti.cpp checkresultreader-ti.hpp)
 mkclass_target(compatlogger.ti compatlogger-ti.cpp compatlogger-ti.hpp)
 mkclass_target(externalcommandlistener.ti externalcommandlistener-ti.cpp externalcommandlistener-ti.hpp)
-mkclass_target(statusdatawriter.ti statusdatawriter-ti.cpp statusdatawriter-ti.hpp)
 
 set(compat_SOURCES
   checkresultreader.cpp checkresultreader.hpp checkresultreader-ti.hpp
   compatlogger.cpp compatlogger.hpp compatlogger-ti.hpp
   externalcommandlistener.cpp externalcommandlistener.hpp externalcommandlistener-ti.hpp
-  statusdatawriter.cpp statusdatawriter.hpp statusdatawriter-ti.hpp
 )
 
 if(ICINGA2_UNITY_BUILD)
@@ -35,11 +33,6 @@ install_if_not_exists(
   ${ICINGA2_CONFIGDIR}/features-available
 )
 
-install_if_not_exists(
-  ${PROJECT_SOURCE_DIR}/etc/icinga2/features-available/statusdata.conf
-  ${ICINGA2_CONFIGDIR}/features-available
-)
-
 install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ICINGA2_FULL_LOGDIR}/compat/archives\")")
 install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ICINGA2_FULL_SPOOLDIR}\")")
 install(CODE "file(MAKE_DIRECTORY \"\$ENV{DESTDIR}${ICINGA2_FULL_INITRUNDIR}/cmd\")")