Skip to content

Commit

Permalink
Fix crash in the unit tests
Browse files Browse the repository at this point in the history
fixes #7769
  • Loading branch information
gunnarbeutner committed Dec 4, 2014
1 parent a134882 commit 7d93788
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 12 deletions.
21 changes: 14 additions & 7 deletions lib/base/application.cpp
Expand Up @@ -108,7 +108,7 @@ void Application::Exit(int rc)
logger->Flush();
}

Timer::Uninitialize();
UninitializeBase();

#ifdef _DEBUG
exit(rc);
Expand Down Expand Up @@ -149,6 +149,18 @@ void Application::InitializeBase(void)
#endif /* _WIN32 */

Utility::ExecuteDeferredInitializers();

/* make sure the thread pool gets initialized */
GetTP();

Timer::Initialize();
}

void Application::UninitializeBase(void)
{
Timer::Uninitialize();

GetTP().Stop();
}

/**
Expand Down Expand Up @@ -316,12 +328,7 @@ void Application::RunEventLoop(void)
DynamicObject::StopObjects();
Application::GetInstance()->OnShutdown();

#ifdef _DEBUG
GetTP().Stop();
m_ShuttingDown = false;

Timer::Uninitialize();
#endif /* _DEBUG */
UninitializeBase();
}

void Application::OnShutdown(void)
Expand Down
1 change: 1 addition & 0 deletions lib/base/application.hpp
Expand Up @@ -43,6 +43,7 @@ class I2_BASE_API Application : public ObjectImpl<Application> {
~Application(void);

static void InitializeBase(void);
static void UninitializeBase(void);

static Application::Ptr GetInstance(void);

Expand Down
8 changes: 5 additions & 3 deletions lib/base/timer.hpp
Expand Up @@ -52,9 +52,6 @@ class I2_BASE_API Timer : public Object

boost::signals2::signal<void(const Timer::Ptr&)> OnTimerExpired;

static void Initialize(void);
static void Uninitialize(void);

class Holder {
public:
Holder(Timer *timer)
Expand Down Expand Up @@ -88,6 +85,11 @@ class I2_BASE_API Timer : public Object
void Call();

static void TimerThreadProc(void);

static void Initialize(void);
static void Uninitialize(void);

friend class Application;
};

}
Expand Down
3 changes: 1 addition & 2 deletions test/test.cpp
Expand Up @@ -31,12 +31,11 @@ struct InitLibBase
InitLibBase(void)
{
Application::InitializeBase();
Timer::Initialize();
}

~InitLibBase(void)
{
Timer::Uninitialize();
Application::UninitializeBase();
}
};

Expand Down

0 comments on commit 7d93788

Please sign in to comment.