Deduplicate and stabilize fragile filesystem transactions #9681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: there were merge conflicts. |
julianbrost
requested changes
Feb 15, 2023
Al2Klimov
force-pushed
the
flush-temp-files-213
branch
from
9339ddf
to
baf2159
Compare
julianbrost
requested changes
Feb 15, 2023
|
Oh, a merge conflict dependency is missing: :) |
by using AtomicFile so they ensure all or nothing of a file gets replaced.
to make them even more atomic.
Al2Klimov
force-pushed
the
flush-temp-files-213
branch
from
baf2159
to
9ea9b10
Compare
julianbrost
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9466