Windows MSI: don't bundle NSClient++ #9703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
area/setup
|
IMAO an awesome accompaniment to #9062! |
|
|
Al2Klimov
force-pushed
the
NSClient++
branch
from
681c177
to
14cdfab
Compare
lippserd
requested review from
lippserd
and removed request for
bobapple and
LordHepipud
lippserd
previously requested changes
Mar 30, 2023
|
The documentation changes are strange as there were places that mentioned the checks shipped with Icinga 2 (very old) and NSClient++ (old), but not Icinga for Windows (new). And now, they mention only the very old stuff. I created #9765 for that. |
9 tasks
julianbrost
approved these changes
May 24, 2023
julianbrost
dismissed
lippserd’s stale review
Instructions on installing NSClient++ got removed since that review (https://github.com/Icinga/icinga2/blob/14cdfab87e3b3ef7d8bd78cf1f5589692be510b3/doc/06-distributed-monitoring.md#nsclient-setup- is no longer in the docs) and everything that's remaining in the docs should be about the checks we're still shipping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to save 32/45 MB. Even if(!) someone still uses it if favor of our PS plugins collection, they can download it by themselves.
TODO