Add option for how to handle null values on boolean conversion

Icinga · Oct 21, 2019 · da8d6f0 · da8d6f0
1 parent d497b5f
commit da8d6f0
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/library/Director/PropertyModifier/PropertyModifierMakeBoolean.php b/library/Director/PropertyModifier/PropertyModifierMakeBoolean.php
@@ -26,6 +26,20 @@ public function getName()
 
     public static function addSettingsFormFields(QuickForm $form)
     {
+        $form->addElement('select', 'null_values', array(
+            'label'       => 'Null values',
+            'required'    => true,
+            'description' => $form->translate(
+                'Your import source may contain null values. You can specifiy'
+                . ' here wether your want to keep them or treat them as invalid'
+            ),
+            'value'        => 'keep',
+            'multiOptions' => $form->optionalEnum(array(
+              'keep'  => $form->translate('Keep'),
+              'invalid'  => $form->translate('Are invalid'),
+            )),
+        ));
+
         $form->addElement('select', 'on_invalid', array(
             'label'       => 'Invalid properties',
             'required'    => true,
@@ -49,7 +63,7 @@ public static function addSettingsFormFields(QuickForm $form)
 
     public function transform($value)
     {
-        if ($value === false || $value === true) {
+        if ($value === false || $value === true || ($value === null && $this->getSetting('null_values') == 'keep')) {
             return $value;
         }