New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance installation docs and add release download URL #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request, sorry for the delay. Reason for not merging it immediately: unrelated formatting changes. The "how to download the module" part equals other modules and is fine.
Regarding the formatting: we try to keep Markdown as readable as possible in your preferred text editor. It's not for web readers only, otherwise we would ship HTML. In case you have good reasons to change parts of it, suggestions are always welcome. They should then be applied to all files equally and handled in a dedicated pull request.
Thanks,
Thomas
My intention with changing the formatting is to later rewrite the entire documentation, following the style we intend to keep with Icinga 2, Icinga Web 2 and modules. It isn't necessarily part of this PR, you're correct here. I'll split this up into a separate PR. |
3719642
to
ebb664f
Compare
@Thomas-Gelf I've extracted the parts relevant for the download URL and methods keeping the current formatting, rebased and force pushed this PR. Please merge :) |
@dnsmichi: before spending a lot of time for reformatting everything please let's eventually discuss the motivation behind that first. There isn't much in this pull request, but for a better understanding please let me address the changes I saw and the objections I have:
...to...
I (personally) consider the first example being more readable in text editors, especially when there is a lot of text. People used to markdown might be fine with the second example, non-tech people might find it easier to scan the document structure with the first one.
We shouldn't get too much into details here, by the end it's not related to this issue at all. I just wanted to explain my point of view on the formerly proposed changes. I'm sure there will be other opinions, so let's find some spare time to address them. Cheers, |
Merged, thanks @dnsmichi! |
One thing about the For now, I'm fine with following the current format and partially adding new content :) Cheers, |
fixes #1648