Use last_state_change::getTimeStamp() in case icingadb module is enabled
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
requested changes
Jun 28, 2023
raviks789
force-pushed
the
fix/last-state-change-icingadb
branch
from
0a0b5e9
to
7fc1abb
Compare
nilmerg
reviewed
Jun 28, 2023
…abled `last_state_change` in case of icingadb module is `DateTime` instance. Hence, we need to call `getTimeStamp` method to get Unix timestamp.
raviks789
force-pushed
the
fix/last-state-change-icingadb
branch
from
7fc1abb
to
28cfddf
Compare
nilmerg
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_state_changein case of icingadb module isDateTimeinstance. Hence, we need to callgetTimeStampmethod to get Unix timestamp.fixes #115