Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring #167

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

TAINCER
Copy link

@TAINCER TAINCER commented Dec 8, 2022

This removes the Multiple Submit Buttons Hacks from ScheduleForm, ReportForm, TemplateForm, and TimeFrameForm. it also adds PHPDocs and Typo annotation where possible.

fixes #164

@TAINCER TAINCER self-assigned this Dec 8, 2022
@cla-bot cla-bot bot added the cla/signed label Dec 8, 2022
@TAINCER TAINCER changed the title Form Refactoring ScheduleForm, TemplateForm, and TimeFrameForm Refactoring Dec 8, 2022
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still being used though!

protected function redirectForm(Form $form, $url)
{
if (
$form->hasBeenSubmitted()
&& ((isset($form->valid) && $form->valid === true)
|| $form->isValid())
) {
$this->redirectNow($url);

library/Reporting/Web/Forms/TemplateForm.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/TemplateForm.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/TemplateForm.php Show resolved Hide resolved
application/controllers/ReportsController.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/ScheduleForm.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/ScheduleForm.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/ScheduleForm.php Outdated Show resolved Hide resolved
@TAINCER TAINCER requested a review from lippserd January 31, 2023 09:25
@TAINCER TAINCER force-pushed the FormRefactor branch 3 times, most recently from bca0436 to d871ba4 Compare January 31, 2023 10:59
@TAINCER TAINCER changed the title ScheduleForm, TemplateForm, and TimeFrameForm Refactoring ScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring Jan 31, 2023
@TAINCER TAINCER force-pushed the FormRefactor branch 2 times, most recently from eb50d97 to 2801c05 Compare January 31, 2023 11:25
@lippserd
Copy link
Member

lippserd commented Feb 2, 2023

@yhabteab Do you want to have a final look here?

Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM as well! :)

@lippserd lippserd merged commit d3cdd00 into master Feb 2, 2023
@lippserd lippserd deleted the FormRefactor branch February 2, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance usage of multiple buttons in a form
3 participants