Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for pgsql backend #15

Open
eizedev opened this issue Nov 8, 2018 · 9 comments
Open

Feature Request: Add support for pgsql backend #15

eizedev opened this issue Nov 8, 2018 · 9 comments

Comments

@eizedev
Copy link

eizedev commented Nov 8, 2018

Hi,

our default database backend system is pgsql, so we use it for all icinga related components.
It causes additional effort, but so far pgsql works quite well with all icinga related components.

So it would be nice if support for pgsql could be added.

One side note: In MariaDB/MySQL you have to mess around with UTF8mb4 if you want 4-byte support, which is default in PostgreSQL UTF8.

Thank you

Greetings René

@Thomas-Gelf
Copy link
Contributor

Absolutely! The ones who have been pushing/sponsoring development had other priorities so far, but sooner or later there will also be PostgreSQL support. You're right about the UTF8 support, that's why this module requires MariaDB/MySQL versions with utf8mb4 support. The schema enforces this, so there is nothing to worry about.

Adding PostgreSQL support means:

  • translate the schema
  • teach the code to handle binary columns differently in various places

We force MySQL into a very strict mode and write/generate our queries in a way that works mostly out of the box on MySQL/MariaDB and PostgreSQL. It's just a little bit annoying that binary columns need special treatment for PostgreSQL. And there are any such columns in this module.

Long story short: PostgreSQL support will be a thing, but it hasn't been scheduled so far.

@eizedev eizedev changed the title Add support for pgsql backend Feature Request: Add support for pgsql backend Dec 1, 2018
@viper539
Copy link

viper539 commented Sep 29, 2019

Hello Thomas,
is it possible that you (or anyone else) could add psql-support for this product?
I didn't trust MySQL because of Oracle.

Thank you,
Viper

@viper539
Copy link

viper539 commented Mar 10, 2020

Hello Thomas,
i really like your good work and i'm happy that i'm able to use it.
Is there a plan to enable this module to work with PostgreSQL?
Can i do anything to push this a bit?
I've heard Dageekeksi could help there.

I would really appreciate it.

Thank you,
Viper

@Thomas-Gelf
Copy link
Contributor

Update, as there has been a related feature request right now: currently there is a block for this in my calendar by the end of October. However, we got no feedback from the potential sponsor since quite some time - so it is not sure whether this will really happen. If anyone is interested to push this: keksi will not help, sponsoring 4 days of development will :D

Tasks, roughly:

  • Create a related schema for PostgreSQL (1 day)
  • Adjust quite some places in the code (2 days, this is tricky - mostly because PostgreSQL handles binary strings differently)
  • Run some intensive tests with different setups (1 day)

Afterwards keeping it up to date and shipping the same migrations as for MySQL/MariaDB is trivial.

@mattboston
Copy link

Would love to have PostgreSQL support. Our organization will not permit MySQL to be installed

@mattboston
Copy link

If anyone is interested to push this: keksi will not help, sponsoring 4 days of development will :D

No guarantees, but how much would it be to sponsor this?

@mattboston
Copy link

Just wondering if anyone had an idea of how much it would be to sponsor this feature?

@lippserd
Copy link
Member

Just wondering if anyone had an idea of how much it would be to sponsor this feature?

Hi,

Unfortunately I have no idea yet, but for such inquiries please contact us at info@icinga.com.

All the best,
Eric

@Thomas-Gelf
Copy link
Contributor

Started working on this, will fade out all places in the code that deal with binary data in a way not suitable for PostgreSQL. Not for the next release, but it will happen

Thomas-Gelf added a commit that referenced this issue Apr 7, 2022
mcodato pushed a commit to WuerthPhoenix/icingaweb2-module-vspheredb that referenced this issue Nov 7, 2022
…ga#15)

Improve test stability

Approved-by: Andrea Avancini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants