Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All transactions should be rolled back on any Exception #24

Closed
Thomas-Gelf opened this issue Nov 9, 2018 · 0 comments
Closed

All transactions should be rolled back on any Exception #24

Thomas-Gelf opened this issue Nov 9, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@Thomas-Gelf
Copy link
Contributor

We currently catch DB-Exceptions in various places and cleanly roll back any pending transaction. Problem is that our assumption is sometimes wrong, there might be non-DB-related Exceptions that could bypass our Exception handling - leaving the transaction in an open state.

See #23 for such an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant