Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualMachine: add link to console via VMRC #141

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

dgoetz
Copy link
Contributor

@dgoetz dgoetz commented Nov 27, 2019

Not sure if it is the best place to display the link and if it should have a config switch to enable/disable or define console type, so feel free to tell me what I should adjust.

Copy link
Contributor

@Thomas-Gelf Thomas-Gelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Could you please address the little formatting issue mentioned inline? Then this would be ready for merge.

@dgoetz
Copy link
Contributor Author

dgoetz commented Nov 27, 2019

Glad you are happy with it! I pushed the change.

@Thomas-Gelf Thomas-Gelf merged commit aa25003 into Icinga:master Nov 27, 2019
@Thomas-Gelf
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants