Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/mysql: Support NSX OpaqueNetwork object types #166

Closed
wants to merge 2 commits into from

Conversation

skupjoe
Copy link

@skupjoe skupjoe commented Jun 3, 2020

No description provided.

@skupjoe
Copy link
Author

skupjoe commented Jun 3, 2020

Looks like I might be duping 62077c4 here, whoops.

Either case, I don't think the adjustment made in f442d29 and 62077c4 as added in that PR are required, so I will leave this open.

@esodesod
Copy link
Contributor

esodesod commented Jun 3, 2020

No worries. Nice summary on Issue #167 - I also noticed the increased varchar was only needed when connected with ESXi-hosts directly (which have different MoRefs). Did not experience the same problem while connected to vCenter directly - with the very same ESXi-hosts (e.g. on VC 6.7). My vCenter-connection broke after upgrading to VC 7.0 (another story/issue), but I didn't have the time to rollback, just to do drilldown in this issue.

Anyway; agree that this needs to be updated, as NSX is getting bigger footprint in vSphere environments, hence need for this object type.

@Thomas-Gelf Thomas-Gelf added this to the v1.2.0 milestone Sep 14, 2020
@Thomas-Gelf Thomas-Gelf self-assigned this Sep 14, 2020
@Thomas-Gelf
Copy link
Contributor

Thanks @skupjoe for tracking this down and for your pull request! I didn't merge your one, as it contained no DB migration and an unreleated merge conflict. Still, it was very useful!

Thomas-Gelf added a commit that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants