Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeLine: Always parse int to validateTime() #5035

Merged

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jun 9, 2023

Php < 8.1 converts fetched time(stamp) to string. This must always be an int.

fixes #5025

@sukhwinder33445 sukhwinder33445 self-assigned this Jun 9, 2023
@cla-bot cla-bot bot added the cla/signed label Jun 9, 2023
@sukhwinder33445 sukhwinder33445 added the bug Something isn't working label Jun 9, 2023
Php < 8.1 converts fetched time(stamp) to string. This must always be an int.
@sukhwinder33445 sukhwinder33445 force-pushed the fix/timline-bubbles-not-displayed-with-phpVer-less-than-81 branch from 4dc910e to d382405 Compare June 9, 2023 14:26
@nilmerg nilmerg added the area/monitoring Affects the monitoring module label Jun 22, 2023
@nilmerg nilmerg merged commit ea1e5f9 into master Jun 22, 2023
@nilmerg nilmerg deleted the fix/timline-bubbles-not-displayed-with-phpVer-less-than-81 branch June 22, 2023 13:05
@nilmerg nilmerg added this to the 2.12.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Affects the monitoring module bug Something isn't working cla/signed
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Timeline does not display any bubbles after upgrade to icingaweb2 2.11
2 participants