Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Properties are deprecated in PHP 8.2 #69

Closed
Fregf opened this issue Feb 23, 2023 · 2 comments · Fixed by #77
Closed

Dynamic Properties are deprecated in PHP 8.2 #69

Fregf opened this issue Feb 23, 2023 · 2 comments · Fixed by #77
Assignees
@lippserd
Labels
enhancement New feature or request
Milestone
v0.7.0

Comments

@Fregf
Copy link

Fregf commented Feb 23, 2023

I'm using Debian Bookworm with icinga-php-library 0.10.1-1 and PHP 8.2. When I log in in icingaweb2, I see three times this message in the left sidebar between the search bar in the menu:
Deprecated: Creation of dynamic property ipl\Sql\Config::$skip_validation is deprecated in /usr/share/icinga-php/ipl/vendor/ipl/sql/src/Config.php on line 32
@nilmerg nilmerg transferred this issue from Icinga/icinga-php-library Feb 23, 2023
@sebastic
Copy link

sebastic commented Feb 23, 2023 •
edited

See also: Debian Bug #1031825 & Icinga/icingaweb2#4918 (comment)

@sebastic
Copy link

As documented in the Debian bugreport, removing the skip_validation option from /etc/icingaweb2/resources.ini resolves the issue.

Adding the resource via icingaweb2 as documented in Icinga DB Web - Database Configuration does not add the option, using the setup wizard does.

The wizard should likely not write the skip_validation option to resources.in, or if that cannot be avoided, the option will need to be added to src/Config.php like the type and ssl resource options.

@TAINCER TAINCER mentioned this issue Feb 24, 2023
Closed
@lippserd lippserd added this to the v0.7.0 milestone Feb 27, 2023
@sebastic sebastic mentioned this issue Mar 23, 2023
Closed
@lippserd lippserd mentioned this issue Jul 19, 2023
Merged
@nilmerg nilmerg modified the milestone: v0.7.0 Jul 19, 2023
@nilmerg nilmerg added the enhancement New feature or request label Jul 19, 2023
lippserd added a commit that referenced this issue Jul 20, 2023
@lippserd
Solidify config (#77)
d3d1413 
 - Fixes PHP 8.2 dynamic properties deprecation warnings
 - Converts keys to camelCase

refs #67
refs #68
fixes #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lippserd lippserd

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Solidify config Icinga/ipl-sql
Solidify config Icinga/ipl-sql
4 participants
@lippserd @sebastic @nilmerg @Fregf